-
-
Notifications
You must be signed in to change notification settings - Fork 486
fix(Select): automatically clear searchValue #1188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
zenggpzqbx
wants to merge
2
commits into
react-component:master
Choose a base branch
from
zenggpzqbx:fix_select_search
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+39
−1
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个
useEffect存在依赖项缺失的问题。它的回调函数中使用了在组件作用域中定义的displayValues、multiple和mode,但它们没有被添加到依赖项数组中。这违反了 React Hooks 的规则,可能会导致 effect 使用了来自先前渲染的陈旧值,从而引发难以追踪的 bug。为了修复这个问题,请将这些变量添加到依赖项数组中。
注意:
onInternalSearch函数也应该被视为一个依赖项。但由于它在每次渲染时都会被重新创建,直接添加它会导致此 effect 在每次渲染时都执行。正确的做法是使用useCallback或useEvent(此文件中已有使用) 来记忆onInternalSearch,然后再将其添加到依赖项数组中。