Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/SelectInput/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,8 @@ export default React.forwardRef<SelectInputRef, SelectInputProps>(function Selec
}

// Open dropdown when a valid open key is pressed
if (isValidateOpenKey(which)) {
const isModifier = event.ctrlKey || event.altKey || event.metaKey;
if (!isModifier && isValidateOpenKey(which)) {
toggleOpen(true);
}
},
Expand Down
30 changes: 30 additions & 0 deletions tests/Select.test.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -1008,6 +1008,36 @@ describe('Select.Basic', () => {
expectOpen(container, true);
});

it('not open on browser hotkeys with modifier keys', () => {
const { container } = render(
<Select>
<Option value="1">1</Option>
<Option value="2">2</Option>
</Select>,
);

const inputEle = container.querySelector('input');

// Ctrl+key combinations (e.g., Ctrl+F for find, Ctrl+S for save)
keyDown(inputEle, KeyCode.F, { ctrlKey: true });
expectOpen(container, false);

keyDown(inputEle, KeyCode.S, { ctrlKey: true });
expectOpen(container, false);

// Alt+key combinations
keyDown(inputEle, KeyCode.F, { altKey: true });
expectOpen(container, false);

// Meta+key combinations (e.g., Cmd+key on Mac)
keyDown(inputEle, KeyCode.F, { metaKey: true });
expectOpen(container, false);

// Regular key without modifiers should still open
keyDown(inputEle, KeyCode.NUM_ONE);
expectOpen(container, true);
});

it('close after select', () => {
const { container } = render(
<Select>
Expand Down
8 changes: 6 additions & 2 deletions tests/utils/common.ts
Original file line number Diff line number Diff line change
Expand Up @@ -110,8 +110,12 @@ export function injectRunAllTimers(jest: Jest) {
});
}

export function keyDown(element: HTMLElement, keyCode: number) {
const event = createEvent.keyDown(element, { keyCode });
export function keyDown(
element: HTMLElement,
keyCode: number,
options?: Partial<KeyboardEvent>,
) {
const event = createEvent.keyDown(element, { keyCode, ...options });
Object.defineProperties(event, {
which: { get: () => keyCode },
});
Expand Down
Loading