Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/react-native/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,10 @@ module.exports = {
return require('./Libraries/Utilities/useWindowDimensions').default;
},
get UTFSequence() {
warnOnce(
'utfsequence-will-be-remove',
'UTFSequence will be removed in a future release.',

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a line on what the user should use instead?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can add, what do @cortinico think can be used instead ?

Comment on lines +372 to +373

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested wording:

Suggested change
'utfsequence-will-be-remove',
'UTFSequence will be removed in a future release.',
'utfsequence-deprecated',
"UTFSequence has been deprecated and will be removed in a future release. Please insert Unicode escape sequences directly, e.g. `'\\ufeff'` (BOM)",

Can we also add an @deprecated JSDoc annotation to the object itself?:

*/
const UTFSequence: {

This comment was marked as outdated.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, yup this is a temporary ongoing thing after the repo move. Please try again in a few hours 🙏🏻

);
return require('./Libraries/UTFSequence').default;
},
get Vibration() {
Expand Down
Loading