Fix tab-order, focusability and auto-focus for modal dialogs#166
Open
AlexeyMz wants to merge 3 commits into
Open
Fix tab-order, focusability and auto-focus for modal dialogs#166AlexeyMz wants to merge 3 commits into
AlexeyMz wants to merge 3 commits into
Conversation
* Exclude collapsed `DropdownMenu` and `UnifiedSearch` content from Tab-navigation. * Exclude canvas elements from Tab-navigation unless the element is only one selected. * Fix Tab-navigation order on `DefaultWorkspace` and `ClassicWorkspace` to generally follow top-to-bottom then left-to-right when moving focus.
* Block canvas interacton (including Tab-navigation) when displaying a blocking modal overlay i.e. an overlay task or viewport-centered dialog.
* Auto-focus within dialogs by default (via `autoFocus` prop) to avoid losing focus when a dialog displayed in the modal overlay or opened by already unmounted trigger element.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DropdownMenuandUnifiedSearchcontent from Tab-navigation.DefaultWorkspaceandClassicWorkspaceto generally follow top-to-bottom then left-to-right when moving focus.autoFocusprop) to avoid losing focus when a dialog displayed in the modal overlay or opened by already unmounted trigger element.