♻️ Update: pagination persist on page reload#269
Closed
ArslanAmeer wants to merge 1 commit intorealworld-apps:mainfrom
Closed
♻️ Update: pagination persist on page reload#269ArslanAmeer wants to merge 1 commit intorealworld-apps:mainfrom
ArslanAmeer wants to merge 1 commit intorealworld-apps:mainfrom
Conversation
Contributor
|
That's a great idea I ant to push for the project but this repository is just an implementation. We need to firstly update the specs. |
Author
|
Sure. |
Contributor
|
Currently implemented as now specified - https://github.com/realworld-apps/realworld/blob/a86e4d72186c3b51bf05f00cd7bf13d59d31b103/specs/e2e/url-navigation.spec.ts#L103 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
The ArticleListComponent would reset to the first page on reloads, losing the current pagination state.
Solution:
Leveraged Angular's ActivatedRoute and Router services to keep the pagination state in sync with a page query parameter in the URL. Now, on initialization, the ArticleListComponent reads the page query parameter to set the initial page, and updates the URL query parameter as the user navigates through the pagination controls. This ensures the current pagination state is retained across reloads or navigation to other pages and back.
@EricSimons @geromegrignon