Fix: Unbound namespaced record field error#259
Open
ayshiff wants to merge 3 commits intoreasonml:masterfrom
Open
Fix: Unbound namespaced record field error#259ayshiff wants to merge 3 commits intoreasonml:masterfrom
ayshiff wants to merge 3 commits intoreasonml:masterfrom
Conversation
facebook-github-bot
added
the
CLA Signed
Contributor
|
Looks good to me, @jordwalke @kyldvs any idea on why these tests were failing? My guess is ocaml version inconsistency with our (soon to be deprecated) internal setup introduced in c7503be ? |
bandersongit
approved these changes
Sep 29, 2020
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@bandersongit has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
ayshiff
force-pushed
the
fix/unbound-namespaced-record-field-error
branch
from
909ce02 to
378b782
Compare
ayshiff
force-pushed
the
fix/unbound-namespaced-record-field-error
branch
from
378b782 to
7fb88ae
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #201
This is what this PR does: