Automatically adjust field of view for widescreen aspect ratios#1322
Automatically adjust field of view for widescreen aspect ratios#1322Calinou wants to merge 1 commit intoredeclipse:masterfrom
Conversation
qreeves
left a comment
qreeves
left a comment
There was a problem hiding this comment.
While I have pointed out an issue with the code, I don't know if this is generally a good idea.
Most people who change FOV are attempting to set specific values and this change results in behaviour which is fairly hidden from the user. Most people would probably be left wondering why the values they set aren't properly reflected.
That being said, it should be noted that FOV is already aspect-corrected in Cube 2 and family on the Y-axis, rather than the X-axis as is being done here. I don't know if this was ported to AC but I do know the change was done in the last decade or so, which is after AC forked from Cube 1.
I think if this were to be merged, it'd need to be an optional component, rather than a forced default, but I invite further discussion on the issue.
The FOV value is now always interpreted as being a 4:3 horizontal FOV value. It will be automatically scaled for different aspect ratios (which results in a horizontal FOV of ~106.26 degrees on 16:9, for example). This provides a better out of the box experience for most players, since 16:9 is the norm for gaming nowadays (or even wider on mobile). Default FOV values were changed to be less extreme at wider aspect ratios.
Calinou
force-pushed
the
use-horplus-fov
branch
from
45b58f0 to
ba3c1cd
Compare
|
|
||
| // automatic FOV adjustment for wide screens | ||
| // (horizontal FOV value is always specified for 4:3, but scaled for different aspect ratios) | ||
| return atan(tan(resultfov * M_PI / 360.0f) * 0.75f * aspect) * 360.0f / M_PI; |
There was a problem hiding this comment.
Since this is a change that drastically changes the expected behavior of the FOV math, this should be behind an additional variable that enables/disables this. Gate it behind "fovaltaspectcorrect" variable and I think it'll be good to merge.
3 participants
Inspired by assaultcube/AC#424.
The FOV value is now always interpreted as being a 4:3 horizontal FOV value. It will be automatically scaled for different aspect ratios (which results in a horizontal FOV of ~106.26 degrees on 16:9, for example).
This provides a better out of the box experience for most players, since 16:9 is the norm for gaming nowadays (or even wider on mobile).
Default FOV values were changed to be less extreme at wider aspect ratios.
Preview
/firstpersonfov 90is used on both screenshots. Aspect ratio is 16:9.Before
After