feat: add ack-secretsmanager-controller#413
Open
tim-stasse wants to merge 1 commit intoredhat-cop:mainfrom
Open
feat: add ack-secretsmanager-controller#413tim-stasse wants to merge 1 commit intoredhat-cop:mainfrom
tim-stasse wants to merge 1 commit intoredhat-cop:mainfrom
Conversation
tim-stasse
requested review from
gnunn1,
pittar and
strangiato
as code owners
strangiato
requested changes
Feb 16, 2026
| kind: Subscription | ||
| metadata: | ||
| name: ack-secretsmanager-controller | ||
| namespace: ack-system |
Contributor
There was a problem hiding this comment.
This should probably include the creation of the namespace
| kind: Kustomization | ||
|
|
||
| resources: | ||
| - ../../base |
Contributor
There was a problem hiding this comment.
Should the secret be included in the resources so it gets created, or is the intention just to show an example of the secret?
If it is intended to just be an example, can we add example to the name of the yaml file?
Comment on lines
+4
to
+5
| name: ack-secretsmanager-user-secrets | ||
| namespace: ack-system |
Contributor
There was a problem hiding this comment.
If this secret is intended to be added to the resources list, we should consider adding the namespace: ack-system to the kustomize file as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.