Improved logging#10
Conversation
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
|
|
||
| response="000" | ||
| count=0 | ||
| while [ "${response}" != "200" ] && [ ${count} -lt ${TIMEOUT} ]; do |
There was a problem hiding this comment.
Overall, good improvement: it keeps trying unless response is 200.
But then, if I get this right, it would also do 120 attemps: TIMEOUT is 120, comment says it's seconds. The check counts the attempts though and turns false once count TIMEOUT.
Wrong?
There was a problem hiding this comment.
yes, it will attempt 120 times before failling. i'm using the same timeout as for waiting on the pod to be in running state.
notice the sleep time ( 1s ) so 120 attempts is indeed nearly that amount of time :)
There was a problem hiding this comment.
ok, still a bit odd to read "do while the number of attempts is lower than the timeout in seconds" 😄
This complaint is more in the realm of nitpicks anyhow.
adietish
left a comment
adietish
left a comment
There was a problem hiding this comment.
+1 beside the TIMEOUT being "number-of-attempts" if my understand is correct (see comment below)
2 participants
No description provided.