Fix java quarkus devfile sample#3
Conversation
Signed-off-by: Stephane Bouchet <sbouchet@redhat.com> Assisted-by: Claude Code (claude-opus-4-6)
|
@RomanNikitenko FYI |
rgrunber
left a comment
There was a problem hiding this comment.
It definitely works, but I just wonder if outright removing those entries is the only way.
| for devfile_url in "${DEVFILE_URL_LIST[@]}"; do | ||
| curl -sL -o ${TMP_DEVFILE} ${devfile_url} | ||
| sed -i 's/^/ /' ${TMP_DEVFILE} | ||
| # Strip commands and events sections — they reference devfile-specific tools |
There was a problem hiding this comment.
Isn't this a bit overkill for https://registry.devfile.io/devfiles/java-quarkus ? It seems like the problem is the init-compile that gets executed as part of postStart is specific to the first entry of starterProjects (with ${PROJECT_SOURCE} ).
Should we maybe avoid injecting the project into the sample if we discover the original devfile has a starterProjects entry ? Is there some other way to get this passing without completely removing the events + commands ?
There was a problem hiding this comment.
good point. i'll try to update this.
i agree we should stick to the original as much as possible
this PR fixes the java-quarkus devfile sample errors.