Skip to content

Fix java quarkus devfile sample#3

Draft
sbouchet wants to merge 1 commit into
mainfrom
fix_java_quarkus
Draft

Fix java quarkus devfile sample#3
sbouchet wants to merge 1 commit into
mainfrom
fix_java_quarkus

Conversation

@sbouchet
Copy link
Copy Markdown
Collaborator

this PR fixes the java-quarkus devfile sample errors.

./dw-auto-validate.sh -s vscode
Using scenario 'vscode'.

Checking oc installation...
Ok!

Checking jq installation...
Ok!

Checking cluster connection...
Ok!
Using current context sbouchet-che/api-che-dev-x6e0-p1-openshiftapps-com:6443/sbouchet


Running test scenario 'vscode' using vscode-test devworkspace in sbouchet-che namespace...
TEST https://registry.devfile.io/devfiles/nodejs with quay.io/devfile/universal-developer-image:ubi10-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/nodejs with quay.io/devfile/universal-developer-image:ubi9-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/nodejs with quay.io/devfile/universal-developer-image:ubi8-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/java-quarkus with quay.io/devfile/universal-developer-image:ubi10-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/java-quarkus with quay.io/devfile/universal-developer-image:ubi9-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/java-quarkus with quay.io/devfile/universal-developer-image:ubi8-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/go with quay.io/devfile/universal-developer-image:ubi10-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/go with quay.io/devfile/universal-developer-image:ubi9-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/go with quay.io/devfile/universal-developer-image:ubi8-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/php-laravel with quay.io/devfile/universal-developer-image:ubi10-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/php-laravel with quay.io/devfile/universal-developer-image:ubi9-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/php-laravel with quay.io/devfile/universal-developer-image:ubi8-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/python with quay.io/devfile/universal-developer-image:ubi10-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/python with quay.io/devfile/universal-developer-image:ubi9-latest PASSED ✅
TEST https://registry.devfile.io/devfiles/python with quay.io/devfile/universal-developer-image:ubi8-latest PASSED ✅

Cleaning up resources...

======================
Summary:
  Total tests: 15 
  Successful: 15
  Failed: 0
  Elapsed time: 7m 48s
======================

Signed-off-by: Stephane Bouchet <sbouchet@redhat.com>
Assisted-by: Claude Code (claude-opus-4-6)
@sbouchet sbouchet requested a review from rgrunber May 20, 2026 10:29
@sbouchet
Copy link
Copy Markdown
Collaborator Author

@RomanNikitenko FYI

@sbouchet sbouchet self-assigned this May 20, 2026
@sbouchet sbouchet moved this to Ready for Review in Eclipse Che Team C Backlog May 20, 2026
Copy link
Copy Markdown
Member

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It definitely works, but I just wonder if outright removing those entries is the only way.

Comment thread dw-auto-validate.sh
for devfile_url in "${DEVFILE_URL_LIST[@]}"; do
curl -sL -o ${TMP_DEVFILE} ${devfile_url}
sed -i 's/^/ /' ${TMP_DEVFILE}
# Strip commands and events sections — they reference devfile-specific tools
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this a bit overkill for https://registry.devfile.io/devfiles/java-quarkus ? It seems like the problem is the init-compile that gets executed as part of postStart is specific to the first entry of starterProjects (with ${PROJECT_SOURCE} ).

Should we maybe avoid injecting the project into the sample if we discover the original devfile has a starterProjects entry ? Is there some other way to get this passing without completely removing the events + commands ?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good point. i'll try to update this.
i agree we should stick to the original as much as possible

@sbouchet sbouchet marked this pull request as draft May 21, 2026 13:45
@sbouchet sbouchet moved this from Ready for Review to 🚧 In Progress in Eclipse Che Team C Backlog May 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants