Skip to content

Show plugin icon in the plugins list#5

Merged
azatsarynnyy merged 1 commit into
mainfrom
icon
May 20, 2026
Merged

Show plugin icon in the plugins list#5
azatsarynnyy merged 1 commit into
mainfrom
icon

Conversation

@azatsarynnyy
Copy link
Copy Markdown
Member

image

Signed-off-by: Artem Zatsarynnyi <azatsary@redhat.com>
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 20, 2026

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 1e87ab56-9fef-4488-8c7a-b19adbd6046c

📥 Commits

Reviewing files that changed from the base of the PR and between 2ee24d3 and cd36029.

⛔ Files ignored due to path filters (1)
  • plugin/src/main/resources/pluginIcon.svg is excluded by !**/*.svg
📒 Files selected for processing (2)
  • build-logic/src/main/kotlin/toolbox/buildlogic/InstallToolboxPlugin.kt
  • build-logic/src/main/kotlin/toolbox/buildlogic/PublishToolboxPlugin.kt

📝 Walkthrough

Summary by CodeRabbit

  • New Features
    • Plugin resources and packages now include an additional icon asset during installation and publishing.

Walkthrough

This PR adds pluginIcon.svg to the Toolbox plugin build pipeline. The resource is included in both the installation sync task and the ZIP packaging task, ensuring the icon appears in deployed and distributed plugin artifacts.

Changes

Plugin Icon Distribution

Layer / File(s) Summary
Install and package pluginIcon.svg
build-logic/src/main/kotlin/toolbox/buildlogic/InstallToolboxPlugin.kt, build-logic/src/main/kotlin/toolbox/buildlogic/PublishToolboxPlugin.kt
The pluginIcon.svg resource is added to the set of files copied during the install task and included in the package ZIP assembly, alongside existing dependencies.json and icon.svg files.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: including a plugin icon file to display in the plugins list, which matches the code changes adding pluginIcon.svg to plugin resources.
Description check ✅ Passed The description provides a screenshot of the plugins management UI showing how plugin icons are displayed, which is directly related to the changeset's goal of showing plugin icons.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@azatsarynnyy azatsarynnyy merged commit 60ecd0a into main May 20, 2026
3 checks passed
@azatsarynnyy azatsarynnyy deleted the icon branch May 20, 2026 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant