fix: add podSecurityLabelSync=true to openshift-gitops

[nmirasch]

What type of PR is this?
/kind bug

What does this PR do / why we need it:
This PR delegate Pod Security Standards (PSS) labeling for OpenShift GitOps namespaces to the cluster.
The operator sets security.openshift.io/scc.podSecurityLabelSync=true on openshift-* namespaces and no longer applies hardcoded pod-security.kubernetes.io/* values itself.

Which issue(s) this PR fixes:

Fixes https://redhat.atlassian.net/browse/GITOPS-9158

Test acceptance criteria:

• Unit Test
• E2E Test

[openshift-ci]

Hi @nmirasch. Thanks for your PR.

I'm waiting for a redhat-developer member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[svghadi]

/ok-to-test

[svghadi]

Thanks @nmirasch . The change looks good to me. I have left some suggestions in the test. Can you take a look?

[nmirasch]

@svghadi rebased!

[nmirasch]

/retest

[svghadi]

/lgtm
/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: svghadi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [svghadi]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[nmirasch]

/retest

[nmirasch]

/retest

[svghadi]

/lgtm

[svghadi]

/cherry-pick v1.20
/cherry-pick v1.19
/cherry-pick v1.18

[openshift-cherrypick-robot]

@svghadi: #1105 failed to apply on top of branch "v1.18":

Applying: fix: add podSecurityLabelSync=true to openshift-gitops
Using index info to reconstruct a base tree...
M	controllers/gitopsservice_controller.go
M	controllers/gitopsservice_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/gitopsservice_controller_test.go
Auto-merging controllers/gitopsservice_controller.go
CONFLICT (content): Merge conflict in controllers/gitopsservice_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: add podSecurityLabelSync=true to openshift-gitops

Details

In response to this:

/cherry-pick v1.20
/cherry-pick v1.19
/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@svghadi: #1105 failed to apply on top of branch "v1.19":

Applying: fix: add podSecurityLabelSync=true to openshift-gitops
Using index info to reconstruct a base tree...
M	controllers/gitopsservice_controller.go
M	controllers/gitopsservice_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/gitopsservice_controller_test.go
Auto-merging controllers/gitopsservice_controller.go
CONFLICT (content): Merge conflict in controllers/gitopsservice_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: add podSecurityLabelSync=true to openshift-gitops

Details

In response to this:

/cherry-pick v1.20
/cherry-pick v1.19
/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-cherrypick-robot]

@svghadi: #1105 failed to apply on top of branch "v1.20":

Applying: fix: add podSecurityLabelSync=true to openshift-gitops
Using index info to reconstruct a base tree...
M	controllers/gitopsservice_controller.go
M	controllers/gitopsservice_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging controllers/gitopsservice_controller_test.go
Auto-merging controllers/gitopsservice_controller.go
CONFLICT (content): Merge conflict in controllers/gitopsservice_controller.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 fix: add podSecurityLabelSync=true to openshift-gitops

Details

In response to this:

/cherry-pick v1.20
/cherry-pick v1.19
/cherry-pick v1.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.