Skip to content

feat(bulk-import): update dev orchestrator version#2747

Open
AndrienkoAleksandr wants to merge 1 commit intoredhat-developer:mainfrom
AndrienkoAleksandr:bulk-import-dev-flow-update-orchestrator
Open

feat(bulk-import): update dev orchestrator version#2747
AndrienkoAleksandr wants to merge 1 commit intoredhat-developer:mainfrom
AndrienkoAleksandr:bulk-import-dev-flow-update-orchestrator

Conversation

@AndrienkoAleksandr
Copy link
Copy Markdown
Contributor

@AndrienkoAleksandr AndrienkoAleksandr commented Apr 10, 2026

What does this pull request do

Update development flow:

  • use newer orchestrator plugin
  • enable orchestrator in the package/app with new frontend system

Changeset

We don't need changeset update, because this is just development flow changes.

Hey, I just made a Pull Request!

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or Updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)

…packages/app

Signed-off-by: Oleksandr Andriienko <oandriie@redhat.com>
@AndrienkoAleksandr AndrienkoAleksandr changed the title feat(bulk-import): update dev orchestrator version, enable it in the … feat(bulk-import): update dev orchestrator version Apr 10, 2026
@rhdh-qodo-merge
Copy link
Copy Markdown

Review Summary by Qodo

Update and enable orchestrator plugin in bulk-import app

✨ Enhancement

Grey Divider

Walkthroughs

Description
• Update orchestrator plugin to version 5.6.0 with form widgets 1.8.0
• Enable orchestrator plugin in bulk-import app frontend
• Update backend orchestrator dependencies to latest versions
• Add orchestrator translations module to app configuration
Diagram
flowchart LR
  A["package.json<br/>Frontend"] -->|"Update to 5.6.0"| B["Orchestrator Plugin"]
  C["package.json<br/>Backend"] -->|"Update to 8.7.3"| B
  B -->|"Import & Register"| D["App.tsx"]
  D -->|"Add to features"| E["NFS App"]
  E -->|"Enable in sidebar"| F["Orchestrator Feature"]
Loading

Grey Divider

File Changes

1. workspaces/bulk-import/packages/app/package.json Dependencies +2/-2

Upgrade frontend orchestrator dependencies

• Updated @red-hat-developer-hub/backstage-plugin-orchestrator from 5.4.2 to ^5.6.0
• Updated @red-hat-developer-hub/backstage-plugin-orchestrator-form-widgets from 1.6.3 to ^1.8.0
• Changed version constraints to use caret (^) for semantic versioning

workspaces/bulk-import/packages/app/package.json


2. workspaces/bulk-import/packages/app/src/App.tsx ✨ Enhancement +14/-7

Enable orchestrator plugin in NFS app

• Import orchestrator plugin and translations module from alpha exports
• Add orchestrator plugin to app features list for sidebar integration
• Add orchestrator translations module to app configuration
• Update app documentation to reflect orchestrator inclusion

workspaces/bulk-import/packages/app/src/App.tsx


3. workspaces/bulk-import/packages/backend/package.json Dependencies +3/-3

Upgrade backend orchestrator dependencies

• Updated @red-hat-developer-hub/backstage-plugin-orchestrator-backend from ^8.5.0 to ^8.7.3
• Updated @red-hat-developer-hub/backstage-plugin-orchestrator-common from ^3.3.0 to ^3.5.3
• Updated @red-hat-developer-hub/backstage-plugin-scaffolder-backend-module-orchestrator from
 ^1.3.0 to ^1.4.3

workspaces/bulk-import/packages/backend/package.json


Grey Divider

Qodo Logo

@rhdh-gh-app
Copy link
Copy Markdown

rhdh-gh-app bot commented Apr 10, 2026

Changed Packages

Package Name Package Path Changeset Bump Current Version
app workspaces/bulk-import/packages/app none v0.0.1
backend workspaces/bulk-import/packages/backend none v0.0.0

@rhdh-qodo-merge
Copy link
Copy Markdown

rhdh-qodo-merge bot commented Apr 10, 2026

Code Review by Qodo

🐞 Bugs (1)   📘 Rule violations (0)   📎 Requirement gaps (0)   🎨 UX Issues (0)
🐞\ ☼ Reliability (1)

Grey Divider


Remediation recommended

1. Orchestrator-common version skew 🐞
Description
The dependency bump to @red-hat-developer-hub/backstage-plugin-orchestrator-common@^3.5.3
introduces two resolved orchestrator-common versions (3.5.2 and 3.5.3) in the workspace. The
bulk-import backend uses orchestrator-common’s generated DefaultApi client against the
Orchestrator backend baseUrl, so resolving a different orchestrator-common version than the
Orchestrator backend increases the chance of client/server OpenAPI contract mismatch and complicates
debugging.
Code

workspaces/bulk-import/packages/backend/package.json[R63-65]

+    "@red-hat-developer-hub/backstage-plugin-orchestrator-backend": "^8.7.3",
+    "@red-hat-developer-hub/backstage-plugin-orchestrator-common": "^3.5.3",
+    "@red-hat-developer-hub/backstage-plugin-scaffolder-backend-module-orchestrator": "^1.4.3",
Evidence
packages/backend now depends on orchestrator-common ^3.5.3, while the bulk-import backend plugin
still depends on orchestrator-common via a looser range and directly uses its generated DefaultApi
against the discovered orchestrator backend base URL. The workspace lockfile resolves both
orchestrator-common 3.5.2 and 3.5.3, indicating the client code and backend plugin can be built
against different orchestrator-common versions.

workspaces/bulk-import/packages/backend/package.json[60-66]
workspaces/bulk-import/plugins/bulk-import-backend/package.json[54-60]
workspaces/bulk-import/plugins/bulk-import-backend/src/service/handlers/import/execute-orchestrator-workflow.ts[18-24]
workspaces/bulk-import/plugins/bulk-import-backend/src/service/handlers/import/execute-orchestrator-workflow.ts[67-73]
workspaces/bulk-import/yarn.lock[12488-12504]

Agent prompt
The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

### Issue description
The PR bumps `@red-hat-developer-hub/backstage-plugin-orchestrator-common` in `packages/backend` to `^3.5.3`, but the workspace now resolves **two** orchestrator-common versions (3.5.2 and 3.5.3). The bulk-import backend plugin uses orchestrator-common’s generated `DefaultApi` client to call the Orchestrator backend, so having it resolve a different orchestrator-common version than the Orchestrator backend increases the risk of client/server contract drift.

### Issue Context
- `packages/backend` now depends on orchestrator-common `^3.5.3`.
- `plugins/bulk-import-backend` depends on orchestrator-common and imports `DefaultApi`/DTOs from it, then calls `discovery.getBaseUrl('orchestrator')`.
- `yarn.lock` shows both orchestrator-common 3.5.2 and 3.5.3 are present.

### Fix Focus Areas
- workspaces/bulk-import/packages/backend/package.json[60-66]
- workspaces/bulk-import/plugins/bulk-import-backend/package.json[54-60]
- workspaces/bulk-import/yarn.lock[12488-12504]

### Suggested fix
1. Update `plugins/bulk-import-backend/package.json` to depend on `@red-hat-developer-hub/backstage-plugin-orchestrator-common` `^3.5.3` (or the exact version you want to standardize on).
2. If you want to guarantee a single version across the workspace, add a workspace-level `resolutions` entry (in `workspaces/bulk-import/package.json`) for `@red-hat-developer-hub/backstage-plugin-orchestrator-common` to the chosen version.
3. Regenerate/update the lockfile so only the intended orchestrator-common version is resolved.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools


Grey Divider

ⓘ The new review experience is currently in Beta. Learn more

Grey Divider

Qodo Logo

@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant