Skip to content

fix(fab): remove fab plugin completely#4889

Open
ciiay wants to merge 1 commit into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin
Open

fix(fab): remove fab plugin completely#4889
ciiay wants to merge 1 commit into
redhat-developer:mainfrom
ciiay:rhidp-13680-remove-fab-plugin

Conversation

@ciiay
Copy link
Copy Markdown
Member

@ciiay ciiay commented May 26, 2026

Description

For RHIDP-13680

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Yi Cai <yicai@redhat.com>
@openshift-ci openshift-ci Bot requested review from rm3l and teknaS47 May 26, 2026 18:09
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 74.39%. Comparing base (360e9c2) to head (cf67943).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4889       +/-   ##
===========================================
+ Coverage   53.65%   74.39%   +20.73%     
===========================================
  Files         121      123        +2     
  Lines        2350     5050     +2700     
  Branches      539      563       +24     
===========================================
+ Hits         1261     3757     +2496     
- Misses       1084     1287      +203     
- Partials        5        6        +1     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 53.65% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 360e9c2...cf67943. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@ciiay
Copy link
Copy Markdown
Member Author

ciiay commented May 27, 2026

/test e2e-ocp-helm

@ciiay
Copy link
Copy Markdown
Member Author

ciiay commented May 27, 2026

/retest

@ciiay
Copy link
Copy Markdown
Member Author

ciiay commented May 28, 2026

/test e2e-ocp-helm

1 similar comment
@ciiay
Copy link
Copy Markdown
Member Author

ciiay commented May 28, 2026

/test e2e-ocp-helm

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

@ciiay: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-helm cf67943 link true /test e2e-ocp-helm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@sanketpathak
Copy link
Copy Markdown
Contributor

sanketpathak commented May 28, 2026

The 1.10 tag might be causing the failure. CI still uses catalog-index 1.10, which was built before that removal

catalogIndex:
image:
registry: quay.io
repository: rhdh/plugin-catalog-index
tag: "1.10"

Copy link
Copy Markdown
Member

@its-mitesh-kumar its-mitesh-kumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants