Skip to content

[WIP] [release-1.10] fix(theme): update theme#4897

Open
christoph-jerolimov wants to merge 1 commit into
redhat-developer:release-1.10from
christoph-jerolimov:theme/update-1.10
Open

[WIP] [release-1.10] fix(theme): update theme#4897
christoph-jerolimov wants to merge 1 commit into
redhat-developer:release-1.10from
christoph-jerolimov:theme/update-1.10

Conversation

@christoph-jerolimov
Copy link
Copy Markdown
Member

Description

This is a manual backport of #4896, need to be confimed first on a cluster and by the release-manager.

Update @red-hat-developer-hub/backstage-plugin-theme from 0.14.4 to 0.14.7 to include this changes:

Which issue(s) does this PR fix

PR acceptance criteria

Please make sure that the following steps are complete:

  • GitHub Actions are completed and successful
  • Unit Tests are updated and passing
  • E2E Tests are updated and passing
  • Documentation is updated if necessary (requirement for new features)
  • Add a screenshot if the change is UX/UI related

How to test changes / Special notes to the reviewer

Signed-off-by: Christoph Jerolimov <jerolimov+git@redhat.com>
@sonarqubecloud
Copy link
Copy Markdown

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 69.60%. Comparing base (63fb98c) to head (2904a0d).

Additional details and impacted files
@@                Coverage Diff                @@
##           release-1.10    #4897       +/-   ##
=================================================
+ Coverage         41.03%   69.60%   +28.57%     
=================================================
  Files               121      111       -10     
  Lines              2220     4702     +2482     
  Branches            539      537        -2     
=================================================
+ Hits                911     3273     +2362     
- Misses             1304     1428      +124     
+ Partials              5        1        -4     
Flag Coverage Δ
install-dynamic-plugins 92.44% <ø> (?)
rhdh 38.81% <ø> (-2.23%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63fb98c...2904a0d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

Copy link
Copy Markdown
Member

@karthikjeeyar karthikjeeyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified the PR image:

  • My Groups background color is set correctly
submenu_background
  • Header doesn't box-shadow doesn't appear when header is positioned above-main-content
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants