Skip to content

chore(e2e): remove remaining migrated plugin tests and CI infrastructure#4898

Open
teknaS47 wants to merge 3 commits into
redhat-developer:mainfrom
teknaS47:e2e-cleanup-remaining
Open

chore(e2e): remove remaining migrated plugin tests and CI infrastructure#4898
teknaS47 wants to merge 3 commits into
redhat-developer:mainfrom
teknaS47:e2e-cleanup-remaining

Conversation

@teknaS47
Copy link
Copy Markdown
Member

Summary

  • Remove E2E tests for remaining migrated plugins (Bulk Import, Orchestrator, Extensions) from the rhdh-plugin-export-overlays repository (Phase 3 — RHIDP-8841)
  • Removes 13 spec files, their exclusive page objects/utils/test data, all Orchestrator CI infrastructure (scripts, operators, SonataFlow setup), and plugin entries from Helm values files, ConfigMaps, and RBAC policies
  • 44 files changed, ~6,398 lines removed

Jira: RHIDP-13952

Tests Removed

Test Files Deleted Config Removed
Orchestrator (9 specs) failswitch-workflow.spec.ts, greeting-workflow.spec.ts, orchestrator-rbac.spec.ts, orchestrator-entity-rbac.spec.ts, orchestrator-entity-workflows.spec.ts, retry-workflow.spec.ts, token-propagation-workflow.spec.ts, ui-props-test-workflow.spec.ts, workflow-all-runs-validations.spec.ts, orchestrator.ts (page object), orchestrator-rbac-helper.ts (API helper) 4 OCI plugin entries from values_showcase.yaml + values_showcase-rbac.yaml; orchestrator: SonataFlow config sections; entity-workflow templates from app-config-rhdh.yaml + app-config-rhdh-rbac.yaml; - orchestrator from pluginsWithPermission; full "Orchestrator Entity-Workflow RBAC" section from rbac-policy.csv; testIgnore entries from 6 Playwright projects; orchestrator disable overrides from 6 diff-values_showcase*.yaml files
Bulk Import bulk-import.spec.ts, bulk-import.ts (page object), bulk-import.ts (test data) 2 wrapper plugin entries from values_showcase.yaml + values_showcase-rbac.yaml; bulkImport: config + catalog URL from app-config-rhdh-rbac.yaml; bulk_import role from rbac-policy.csv, rbac-constants.ts, and authentication-providers/yamls/rbac-policy.csv; testIgnore entries from Playwright config
Extensions extensions.spec.ts, extensions.ts (page object) 3 wrapper plugin entries from values_showcase.yaml + values_showcase-rbac.yaml; extensions: config from app-config-rhdh.yaml; extension role from rbac-policy.csv + rbac-constants.ts; extensions-catalog volume mount + volume from values_showcase-rbac.yaml + 6 diff-values_showcase-rbac_*.yaml files

CI Infrastructure Removed

  • .ci/pipelines/lib/orchestrator.sh — entire file deleted (SonataFlow deployment, workflow management, plugin enablement functions)
  • .ci/pipelines/lib/operators.sh — removed operator::install_serverless_logic() and operator::install_serverless() (SonataFlow/Knative operator installs)
  • .ci/pipelines/utils.sh — removed all orchestrator delegation functions (should_skip_orchestrator, deploy_orchestrator_workflows, enable_orchestrator_plugins_op, install_orchestrator_infra_chart, disable_orchestrator_plugins_in_values); simplified base_deployment(), rbac_deployment(), cluster_setup_ocp_helm(), cluster_setup_ocp_operator() by removing orchestrator conditional logic; removed serverless operator installs from cluster_setup_ocp_operator()
  • .ci/pipelines/jobs/upgrade.sh — removed deploy_orchestrator_workflows call
  • .ci/pipelines/jobs/ocp-operator.sh — removed commented-out orchestrator deployment calls and "(orchestrator disabled)" log messages
  • .ci/pipelines/jobs/ocp-nightly.sh — removed "(orchestrator disabled)" log messages
  • diff-values_showcase_PR.yaml, diff-values_showcase-rbac_PR.yaml, diff-values_showcase_upgrade.yaml, diff-values_showcase_OSD-GCP.yaml, diff-values_showcase-rbac_OSD-GCP.yaml — cleared orchestrator override content
  • diff-values_showcase-sanity-plugins.yaml — removed orchestrator: enabled section
  • diff-values_showcase_{AKS,EKS,GKE}.yaml — removed orchestrator plugin disable entries and orchestrator: null
  • diff-values_showcase-rbac_{AKS,EKS,GKE}.yaml — removed orchestrator plugin disable entries, extensions-catalog volume mounts/volumes, and orchestrator: null

Documentation Updated

  • docs/e2e-tests/CI-medic-guide.md — removed 5 stale references to orchestrator infrastructure, orchestrator.sh, and orchestrator workflow steps
  • .ci/pipelines/lib/README.md — removed orchestrator.sh module section and stale serverless function references

Shared Dependencies Preserved

  • Keycloak catalog backend (backstage-community-plugin-catalog-backend-module-keycloak-dynamic) kept — still required by remaining tests
  • catalog.providers.keycloakOrg kept in both app-config files
  • KEYCLOAK_AUTH_* env vars kept — used by OIDC auth provider
  • RBAC support files (rbac-api.ts, rbac.ts, rbac-constants.ts, rhdh-auth-api-hack.ts) kept — still used by auditor-rbac.spec.ts and other remaining tests
  • home-page-customization.spec.ts retained with Quick Access verification

Test plan

  • OCP Helm PR job (showcase + showcase-rbac) — validates deployment with removed plugins and remaining tests pass
  • OCP Helm Nightly job — validates showcase-sanity-plugins, localization, and runtime
  • OCP Operator job — validates showcase-operator + showcase-operator-rbac

@github-actions
Copy link
Copy Markdown
Contributor

The container image build workflow finished with status: cancelled.

@teknaS47
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm-nightly
/test e2e-ocp-operator-nightly

@teknaS47
Copy link
Copy Markdown
Member Author

/hold till redhat-developer/rhdh-plugin-export-overlays#1972 is merged

@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 52.86%. Comparing base (105732d) to head (f9a8a7d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4898      +/-   ##
==========================================
- Coverage   53.65%   52.86%   -0.80%     
==========================================
  Files         121      109      -12     
  Lines        2350     2132     -218     
  Branches      539      536       -3     
==========================================
- Hits         1261     1127     -134     
+ Misses       1084     1004      -80     
+ Partials        5        1       -4     
Flag Coverage Δ
rhdh 52.86% <ø> (-0.80%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 105732d...f9a8a7d. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions
Copy link
Copy Markdown
Contributor

Image was built and published successfully. It is available at:

@teknaS47
Copy link
Copy Markdown
Member Author

/test e2e-ocp-helm-nightly
/test e2e-ocp-operator-nightly

@github-actions
Copy link
Copy Markdown
Contributor

The container image build and publish workflows were skipped (either due to [skip-build] tag or no relevant changes with existing image).

@sonarqubecloud
Copy link
Copy Markdown

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 28, 2026

@teknaS47: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ocp-operator-nightly 9d29a6f link false /test e2e-ocp-operator-nightly
ci/prow/e2e-ocp-helm-nightly 9d29a6f link false /test e2e-ocp-helm-nightly

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant