docs: clarify inventory file setup and fix ansible command path#12
Open
lautou wants to merge 1 commit intoredhat-solution-patterns:mainfrom
Open
docs: clarify inventory file setup and fix ansible command path#12lautou wants to merge 1 commit intoredhat-solution-patterns:mainfrom
lautou wants to merge 1 commit intoredhat-solution-patterns:mainfrom
Conversation
The inventory file setup instructions were unclear due to: 1. Missing directory context - the path 'inventories/inventory.template' only works after 'cd operator-setup', but the instruction to open the file appeared before the cd command 2. Missing copy step - users should copy the template to avoid editing version-controlled files 3. Wrong filename - ansible-playbook command referenced 'inventory.template' instead of the copied 'inventory' file Changes: - Add explicit 'cd operator-setup' before the copy command - Add 'cp inventories/inventory.template inventories/inventory' command - Update instructions to reference 'inventory' instead of 'inventory.template' - Fix ansible-playbook command to use 'inventories/inventory' This prevents confusion about file paths and follows Git best practices by not editing version-controlled template files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Member
|
Thanks for the PR. I’m OOO at present. Will merge early next week |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The inventory file setup instructions were unclear due to:
Changes:
This prevents confusion about file paths and follows Git best practices by not editing version-controlled template files.