add GatewayClass prerequisite documentation to deployment guide#13
Open
lautou wants to merge 2 commits intoredhat-solution-patterns:mainfrom
Open
add GatewayClass prerequisite documentation to deployment guide#13lautou wants to merge 2 commits intoredhat-solution-patterns:mainfrom
lautou wants to merge 2 commits intoredhat-solution-patterns:mainfrom
Conversation
The inventory file setup instructions were unclear due to: 1. Missing directory context - the path 'inventories/inventory.template' only works after 'cd operator-setup', but the instruction to open the file appeared before the cd command 2. Missing copy step - users should copy the template to avoid editing version-controlled files 3. Wrong filename - ansible-playbook command referenced 'inventory.template' instead of the copied 'inventory' file Changes: - Add explicit 'cd operator-setup' before the copy command - Add 'cp inventories/inventory.template inventories/inventory' command - Update instructions to reference 'inventory' instead of 'inventory.template' - Fix ansible-playbook command to use 'inventories/inventory' This prevents confusion about file paths and follows Git best practices by not editing version-controlled template files. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Documents the missing GatewayClass "istio" prerequisite that must exist before running the Ansible playbook. Includes: - Detection command to check if GatewayClass exists - Two creation methods (automatic via Ingress Operator, manual creation) - Important notes about RHOAI and Istio control plane auto-creation - Updated prerequisites checklist This addresses a gap in the original deployment documentation where GatewayClass creation was assumed but not documented. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a comprehensive "GatewayClass Prerequisite" section to 03-demo.adoc that includes:
Why this is needed
During deployment testing, we discovered that:
This creates a deployment blocker for users following the guide, as they'll encounter errors with no clear resolution path.
Impact
✅ Users will now know:
Testing
Verified on OpenShift 4.19 cluster with: