DOC-2457 - Adds code examples for the string tutorial#2635
Closed
justincastilla wants to merge 4 commits intoredis:emb-examplesfrom
Closed
DOC-2457 - Adds code examples for the string tutorial#2635justincastilla wants to merge 4 commits intoredis:emb-examplesfrom
justincastilla wants to merge 4 commits intoredis:emb-examplesfrom
Conversation
dwdougherty
suggested changes
Jan 16, 2024
dwdougherty
left a comment
dwdougherty
left a comment
There was a problem hiding this comment.
Collection name is incorrect. Two step names need correction. Superfluous HIDE_START.
| await client.flushDb(); | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START set |
There was a problem hiding this comment.
Suggested change
| // STEP_START set | |
| // STEP_START set_get |
| assert.equal(res2, 'Deimos'); | ||
| // REMOVE_END | ||
|
|
||
| // STEP_START set_nx_xx |
There was a problem hiding this comment.
Suggested change
| // STEP_START set_nx_xx | |
| // STEP_START setnx_xx |
| @@ -0,0 +1,69 @@ | |||
| // EXAMPLE: string_tutorial | |||
There was a problem hiding this comment.
Needs to match what's in the CLI example.
Suggested change
| // EXAMPLE: string_tutorial | |
| // EXAMPLE: set_tutorial |
| // REMOVE_END | ||
|
|
||
| // STEP_START set_nx_xx | ||
| // HIDE_START |
| // REMOVE_START | ||
| assert.equal(res7, 1); | ||
| assert.equal(res8, 11); | ||
| // REMOVE_END |
sjpotter
reviewed
Jun 13, 2024
|
|
||
| // STEP_START set | ||
| const res1 = await client.set("bike:1", "Deimos"); | ||
| console.log(res1); // true |
Contributor
There was a problem hiding this comment.
in v5, return OK, not true
sjpotter
reviewed
Jun 13, 2024
| // STEP_START set_nx_xx | ||
| // HIDE_START | ||
| const res3 = await client.set("bike:1", "bike", 'NX'); | ||
| console.log(res3); // None |
Contributor
There was a problem hiding this comment.
Unsure what None means here (checking that its OK below)
|
This pull request has been automatically marked as stale due to inactivity. |
|
This pull request has been automatically closed due to inactivity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses this ticket:
https://redislabs.atlassian.net/browse/DOC-2457
Checklist
npm testpass with this change (including linting)?