DOC 2644 - adds Stream examples in Node.js#2654
DOC 2644 - adds Stream examples in Node.js#2654justincastilla wants to merge 1 commit intoredis:emb-examplesfrom
Conversation
| 'location_id': '1' | ||
| } | ||
| ); | ||
| console.log(res1); // >>> 1700073067968-0 |
There was a problem hiding this comment.
without context of how comments here were done before, what is this implying, that it should be greater than that value?
| count: 100, | ||
| block: 300 | ||
| }); | ||
| console.log(res5); // >>> [['race:france', [('1692629576966-0', {'rider': 'Castilla', 'speed': '30.2', 'position': '1', 'location_id': '1'}), ('1692629594113-0', {'rider': 'Norem', 'speed': '28.8', 'position': '3', 'location_id': '1'}), ('1692629613374-0', {'rider': 'Prickett', 'speed': '29.7', 'position': '2', 'location_id': '1'})]]] |
There was a problem hiding this comment.
note that these id values dont correspond to the comments above, perhaps there should be more consistency in how we refer to variable" settings (ala IDs)
| // STEP_END | ||
|
|
||
| // STEP_START xRange_time | ||
| const res12 = await client.xRange('race:france', '1692629576965', '1692629576967'); |
There was a problem hiding this comment.
because of the above mentioned id issue, this now can fail,
| const res16 = await client.xRevRange('race:france', '+', '-', 1); | ||
| console.log( | ||
| res16 | ||
| ); // >>> [('1692629676124-0', {'rider': 'Castilla', 'speed': '29.9', 'position': '1', 'location_id': '2'})] |
There was a problem hiding this comment.
I'm getting all 4 results here, doesn't seem ID based?
|
my primary comment here (which makes it harder to test) is that the IDs generated dont correspond to what a user would see if running it themselves, which then breaks the rest of the example code. |
|
This pull request has been automatically marked as stale due to inactivity. |
|
This pull request has been automatically closed due to inactivity. |
2 participants
Description
DOC-2644
Checklist
npm testpass with this change (including linting)?