Fix search pagination in list messages #2177
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bound pageIndex to valid range based on filtered results so searching while on page 2+ shows results instead of empty page. The original pageIndex is preserved so clearing the search returns to the same page.
jvorcak
reviewed
Jan 26, 2026
|
|
||
| // Message Table rendering variables and functions | ||
| // Bound pageIndex to valid range based on filtered results | ||
| const totalPages = Math.max(1, Math.ceil(filteredMessages.length / pageSize)); |
Collaborator
There was a problem hiding this comment.
isn't there some util function for this already?, if not shouldn't there be some?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes an issue where searching/filtering messages while on page 2+ would show no results because the pagination index exceeded the filtered result set.
Changes
pageIndexto valid range based on filtered results countpageIndexstate so clearing the search returns to the same pageTest plan