[UX-848] frontend: fix loose checking for connector default override #2195
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r-vasquez
changed the title
In 0fc7832 we changed: - if (this.appliedConfig == null) + if (this.appliedConfig === null) But appliedConfig is typed as Record<string, unknown> | undefined, never null. The loose equality (undefined == null) was true, so the custom_default_value loop ran correctly. The strict equality (undefined === null) is false, so the loop was skipped for new connectors.
malinskibeniamin
approved these changes
Jan 29, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 0fc7832#diff-92ae9a9521b7b474ece84f42374e19b87b24019769ef6603b63ba604f5bc4677 we fixed several issues across the codebase to satisfy the linter/formatter. One of those changes was:
/state/connect/state.ts
However,
appliedConfigcan never actually benull, since it is typed asRecord<string, unknown> | undefined.Previously, the loose abstract equality check made this a non-issue because
undefined == nullevaluates totrue. After switching to strict equality,undefined === nullis alwaysfalse, which meant we were skipping the loop where the default configuration values were overridden.