Fix nightly build versions using stale ancestor tags#1362
Merged
andrewstucki merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
82745cf to
6165a13
Compare
RafalKorepta
approved these changes
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nightly builds on main produce versions like
v25.2.1-beta1-152-g39b30399cbecausegit describepicks the nearest ancestor tag, which was our initial beta cut of 25.2.1 which appears to have been tagged directly frommainrather than a release branch. Since we now cut release tags (e.g., operator/v25.3.2) on release branches rather than main, the nearest reachable tag on main is super old and we have misleading version strings in nightly artifacts.This adds support for an optional
NEXT_VERSIONfile per module (e.g., operator/NEXT_VERSION). When the file exists and HEAD is not on an exact tag, ci/scripts/version.sh replaces the stale tag-derived version prefix with the contents of NEXT_VERSION, preserving the commit distance and hash suffix from git describe.Behavior is unchanged when: