Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/reflex-base/src/reflex_base/components/component.py
Original file line number Diff line number Diff line change
Expand Up @@ -1750,7 +1750,12 @@ def _get_all_imports(self, collapse: bool = False) -> ParsedImportDict:
The import dict with the required imports.
"""
imports_ = imports.merge_parsed_imports(
self._get_imports(), *[child._get_all_imports() for child in self.children]
self._get_imports(),
*[child._get_all_imports() for child in self.children],
*[
component._get_all_imports()
for component in self._get_components_in_props()
],
)
return imports.collapse_imports(imports_) if collapse else imports_

Expand Down
26 changes: 26 additions & 0 deletions tests/units/components/test_component.py
Original file line number Diff line number Diff line change
Expand Up @@ -522,6 +522,32 @@ def test_get_imports(component1, component2):
}


def test_get_all_imports_includes_components_in_props():
"""Test that _get_all_imports collects imports from components in props."""

class InnerComponent(Component):
"""A component that requires a specific import."""

def _get_imports(self) -> ParsedImportDict:
return {"some-library": [ImportVar(tag="SomeTag")]}

class OuterComponent(Component):
"""A component with a component-typed prop."""

fallback: Component | None = None

def _get_imports(self) -> ParsedImportDict:
return {"outer-library": [ImportVar(tag="OuterTag")]}

inner = InnerComponent.create()
outer = OuterComponent.create(fallback=inner)
all_imports = outer._get_all_imports()
assert "some-library" in all_imports, (
"_get_all_imports() should collect imports from components in props"
)
assert "outer-library" in all_imports


def test_get_custom_code(component1: Component, component2: Component):
"""Test getting the custom code of a component.

Expand Down
Loading