Skip to content
This repository was archived by the owner on Mar 5, 2020. It is now read-only.

Proposed fix for issue #1.#25

Open
cxj wants to merge 1 commit into
relayphp:1.xfrom
cxj:patch-4
Open

Proposed fix for issue #1.#25
cxj wants to merge 1 commit into
relayphp:1.xfrom
cxj:patch-4

Conversation

@cxj

@cxj cxj commented Jun 8, 2017

Copy link
Copy Markdown
Contributor

No description provided.

@pmjones

pmjones commented Jun 9, 2017

Copy link
Copy Markdown
Contributor

@cxj Given your followup comment in #24 do you still consider this a good fix?

@cxj

cxj commented Jun 9, 2017

Copy link
Copy Markdown
Contributor Author

I suspect this fix is inadequate. What's needed is for the calling code to be notified in some way of the error, so that it can log or otherwise handle it in an appropriate way.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants