Skip to content

Update our app fees doc#280

Closed
pedromcunha wants to merge 5 commits intomainfrom
feature/update-fees-doc
Closed

Update our app fees doc#280
pedromcunha wants to merge 5 commits intomainfrom
feature/update-fees-doc

Conversation

@pedromcunha
Copy link
Copy Markdown
Member

No description provided.

@pedromcunha pedromcunha requested a review from ptrwtts March 19, 2026 21:27
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 19, 2026

Claude finished @pedromcunha's task in 47s —— View job


Code Review

  • Gather context and read changed files
  • Review changes against documentation standards
  • Post review feedback

Overall: Looks good! This is a solid documentation update that improves clarity and accuracy across the fees page. Here's my detailed review:

What's good

  • Relay Fees description improved: The old description ("25% of swap fees and app fee") is replaced with a much clearer explanation about flat basis point fees. This is more informative for integrators.
  • Fixed backtick formatting: expanded price impactexpandedPriceImpact — this now matches the actual API field name, which is important for developers referencing it.
  • Expanded Price Impact descriptions: Each field now includes helpful context (e.g., what "execution" covers, what "swap" includes). Much better for discoverability.
  • New sponsored field documented: Good addition reflecting the fee sponsorship feature.
  • New Tip callout and Fee Sponsorship section: The recommended display mapping and sponsorship details are useful additions for integrators.

Minor suggestions

  1. Line 26 — trailing backslashes:

    ...please check out our [App Fees Doc](/features/app-fees).\
    \
    

    These trailing backslashes for line continuation are a bit unusual in MDX. Consider removing them and using a normal paragraph break instead. This was pre-existing, not introduced in this PR, so not a blocker.

  2. Line 32 — "Relay related fee" phrasing:

    These fees are only the Relay related fee, and are segmented as the following fees:
    

    Minor: "Relay related fee" could be clearer as "Relay-related fees" (hyphenated, plural). Also pre-existing.

  3. Line 69 — sponsoredFeeComponents parameter reference: Consider formatting as sponsoredFeeComponents (bold + backticks) to match the CLAUDE.md convention for parameter names. Currently it's just bold.

    Fix this →

  4. Line 67 — subsidizeFees formatting: Same as above — already correctly uses subsidizeFees (bold + backticks). Nice consistency there.

No blocking issues. Approving this as-is — the suggestions above are optional polish.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 24, 2026

Claude finished @vezzabel's task in 54s —— View job


Code Review

  • Gather context and read changed files
  • Review changes against documentation standards
  • Post review feedback

Overall: Looks good! This PR significantly improves the fees documentation with clearer descriptions, a new fee rate table, expanded price impact details, and a new Fee Sponsorship section.

What's good

  • Relay Fees clarity: Replacing the vague "25% of swap fees and app fee" with a detailed fee rate table by asset type and volume tier is a big improvement for integrators.
  • Fixed field name: expanded price impactexpandedPriceImpact now matches the actual API response.
  • Expanded Price Impact descriptions: Each field now explains what it covers — much more useful.
  • New sponsored field + Fee Sponsorship section: Good additions reflecting the fee sponsorship feature, with proper cross-links.
  • Tip callout: The recommended display mapping is a practical addition for integrators building UIs.

Suggestions

  1. Line 33–34 — trailing backslashes:

    ...please check out our [App Fees Doc](/features/app-fees).\
    \
    

    These trailing backslashes create hard line breaks in MDX. A normal paragraph break (blank line) would be cleaner. Pre-existing, not a blocker.

  2. Line 39 — "Relay related fee" phrasing:

    These fees are only the Relay related fee, and are segmented as the following fees:
    

    Minor: "Relay-related fees" (hyphenated, plural) reads better. Also pre-existing.

  3. Line 55–63 — Price Impact field names: The field names (execution, swap, relay, app, sponsored) are API response fields. Per the CLAUDE.md convention, parameter/field names should be formatted as fieldName (bold + backticks). Currently they use bold only.

    Fix this →

  4. Line 76 — sponsoredFeeComponents formatting: Should be sponsoredFeeComponents (bold + backticks). Currently it's just bold without backticks.

    Fix this →

  5. Lines 41–49 — Fees Object field names: Same formatting issue — relayerService, relayerGas, relayer, app, subsidized should all use backticks inside the bold. Pre-existing but worth fixing for consistency.

No blocking issues — approving as-is. The suggestions above are optional polish for formatting consistency.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Claude finished @vezzabel's task in 49s —— View job


Code Review

  • Gather context and read changed files
  • Review changes against documentation standards
  • Post review feedback

Overall: Looks good! This PR is a solid improvement to the fees documentation — the new fee rate table, expanded price impact descriptions, and Fee Sponsorship section all add valuable clarity for integrators.

What's good

  • Fee rate table: Replacing the vague "25% of swap fees and app fee" with a structured table by asset type and volume tier is a major clarity improvement.
  • Fee category definitions: The new category descriptions (same token bridging, stablecoin swaps, etc.) make the fee structure self-explanatory.
  • Fixed field name: expanded price impactexpandedPriceImpact — now matches the actual API response.
  • Richer Price Impact descriptions: Each field now explains what it covers, much more useful for integrators.
  • New sponsored field + Fee Sponsorship section: Good additions with proper cross-links.
  • Tip callout: The recommended display mapping is practical for UI builders.
  • Escaped dollar sign fix: \$0.02$0.02 — cleaner MDX.

Suggestions

  1. Lines 47–55 — Fees Object field names: Per CLAUDE.md, parameter/field names should use backticks inside bold. Currently these are bold-only:

    • **relayerService****relayerService**
    • **relayerGas****relayerGas**
    • **relayer****relayer**
    • **app****app**
    • **subsidized****subsidized**

    Pre-existing, but worth fixing for consistency.

    Fix this →

  2. Lines 61–69 — Price Impact field names: Same issue — execution, swap, relay, app, sponsored should all be fieldName (bold + backticks).

    Fix this →

  3. Lines 73–75 — Tip callout field names: The field references inside the Tip (relay, app, swap, execution) should also use backticks for consistency.

    Fix this →

  4. Lines 39–40 — Trailing backslashes: The \ at end of lines 39–40 create hard line breaks in MDX. A normal blank line paragraph break would be cleaner. Pre-existing, not a blocker.

  5. Line 32 — "USDs" capitalization: The Major token swaps category references "USDs" (lowercase 's') while line 31 uses "USDS" (uppercase). Should likely be consistent — USDS.

    Fix this →

No blocking issues — approving as-is. The suggestions above are optional polish for formatting consistency.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Claude finished @pedromcunha's task in 44s —— View job


Code Review

  • Gather context and read changed files
  • Review changes against documentation standards
  • Post review feedback

Overall: Looks good! This PR significantly improves the fees documentation — the new fee rate table, expanded price impact descriptions, fee category definitions, and Fee Sponsorship section are all valuable additions for integrators.

What's good

  • Fee rate table: Replacing the vague "25% of swap fees and app fee" with a structured table by asset type and volume tier is a major clarity win.
  • Fee category definitions: The new descriptions (same token bridging, stablecoin swaps, etc.) make the fee structure self-explanatory.
  • Fixed field name: expanded price impactexpandedPriceImpact — now matches the actual API response.
  • Richer Price Impact descriptions: Each field now explains what it covers concretely.
  • New sponsored field + Fee Sponsorship section: Good additions with proper cross-links to the feature doc.
  • Tip callout: The recommended display mapping is practical for UI builders.
  • Escaped dollar sign fix: \$0.02$0.02 — cleaner MDX.

Suggestions

  1. Lines 47–55 — Fees Object field names: Per CLAUDE.md, parameter/field names should use backticks inside bold. Currently these are bold-only:

    • **relayerService**relayerService
    • **relayerGas**relayerGas
    • **relayer**relayer
    • **app**app
    • **subsidized**subsidized

    Pre-existing, but worth fixing for consistency.

    Fix this →

  2. Lines 61–69 — Price Impact field names: Same issue — execution, swap, relay, app, sponsored should all use bold + backticks formatting.

    Fix this →

  3. Lines 73–75 — Tip callout field names: The field references inside the Tip (relay, app, swap, execution) should also use bold + backticks for consistency.

    Fix this →

  4. Line 32 — "USDs" inconsistency: Line 31 references "USDS" (uppercase) but line 32 uses "USDs" (lowercase 's'). Should be consistent — likely USDS.

    Fix this →

  5. Lines 39–40 — Trailing backslashes: The \ at end of lines 39–40 create hard line breaks in MDX. A normal blank line paragraph break would be cleaner. Pre-existing, not a blocker.

No blocking issues — the suggestions above are optional polish for formatting consistency.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Claude finished @pedromcunha's task in 56s —— View job


Code Review

  • Gather context and read changed files
  • Review changes against documentation standards
  • Post review feedback

Overall: Looks good! This PR is a substantial improvement to the fees documentation — the new fee rate table, fee category definitions, expanded price impact descriptions, and Fee Sponsorship section all add valuable clarity for integrators. Approved by ted-palmer already.

What's good

  • Fee rate table: Replacing the vague "25% of swap fees and app fee" with a structured table by asset type and volume tier is a major clarity win.
  • Fee category definitions: The new descriptions make the fee structure self-explanatory for integrators.
  • Fixed field name: expanded price impactexpandedPriceImpact — now matches the actual API response.
  • Richer Price Impact descriptions: Each field now explains what it covers concretely.
  • New sponsored field + Fee Sponsorship section: Good additions with proper cross-links.
  • Tip callout: The recommended display mapping is practical for UI builders.
  • Escaped dollar sign fix: \$0.02$0.02 — cleaner MDX.

Suggestions

  1. Lines 47–55 — Fees Object field names: Per CLAUDE.md, parameter/field names should use bold + backticks. Currently these are bold-only:

    • **relayerService**`relayerService`
    • **relayerGas**`relayerGas`
    • **relayer**`relayer`
    • **app**`app`
    • **subsidized**`subsidized`

    Pre-existing, but worth fixing for consistency.

    Fix this →

  2. Lines 61–69 — Price Impact field names: Same issue — execution, swap, relay, app, sponsored should all use bold + backticks.

    Fix this →

  3. Lines 73–75 — Tip callout field names: The field references inside the Tip (relay, app, swap, execution) should also use bold + backticks for consistency.

    Fix this →

  4. Line 32 — "USDs" inconsistency: Line 31 references "USDS" (uppercase) but line 32 uses "USDs" (lowercase 's'). Should be consistent — likely USDS.

    Fix this →

  5. Lines 39–40 — Trailing backslashes: The \ at end of lines 39–40 create hard line breaks in MDX. A normal blank line paragraph break would be cleaner. Pre-existing, not a blocker.

No blocking issues. The suggestions above are optional polish for formatting consistency.

@pedromcunha
Copy link
Copy Markdown
Member Author

Unfortunately there are unsigned commits in here, going to just open up a new PR since it's just 1 file change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants