Skip to content

Fix/fee doc table formatting#286

Merged
pedromcunha merged 5 commits intomainfrom
fix/fee-doc-table-formatting
Mar 27, 2026
Merged

Fix/fee doc table formatting#286
pedromcunha merged 5 commits intomainfrom
fix/fee-doc-table-formatting

Conversation

@pedromcunha
Copy link
Copy Markdown
Member

No description provided.

ted-palmer
ted-palmer previously approved these changes Mar 27, 2026
@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Claude finished @pedromcunha's task in 37s —— View job


Code Review: Fix/fee doc table formatting

  • Gather context and review PR changes
  • Analyze code quality and formatting
  • Post review feedback

🔴 Critical: Unresolved Merge Conflicts

The file references/api/api_core_concepts/fees.mdx contains unresolved merge conflict markers that were committed to the branch. There are three conflict blocks (lines 35-39, 46-50, 57-61):

<<<<<<< fix/fee-doc-table-formatting
         <td>{'< $10M'}</td>
=======
         <td>&lt; $10M</td>
>>>>>>> main

This will break the page rendering. The conflicts need to be resolved before merging.

Reviewing the Intended Changes

The branch side uses JSX expression syntax ({'< $10M'}, {'$10M – $100M'}, {'$100M – $1B'}) while main uses HTML entities / raw text (&lt; $10M, $10M – $100M, $100M – $1B).

Both approaches are valid in MDX, but the JSX expression syntax ({'< $10M'}) is the better choice for the < $10M cell since the < character can be misinterpreted as an HTML tag in MDX. However, the other two cells ($10M – $100M and $100M – $1B) don't contain characters that need escaping, so wrapping them in JSX expressions is unnecessary — the main versions are fine for those.

Recommendation

Resolve the merge conflicts by keeping:

  • {'< $10M'} for the first row (correctly escapes < for MDX)
  • $10M – $100M for the second row (no escaping needed)
  • $100M – $1B for the third row (no escaping needed)

Alternatively, if you prefer consistency across all three cells, use the JSX expression syntax for all of them — that's fine too, just remove the conflict markers.

Fix this →

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2026

Claude finished @pedromcunha's task in 31s —— View job


Code Review: Fix/fee doc table formatting

  • Gather context and review PR changes
  • Analyze code quality and formatting
  • Post review feedback

The merge conflicts from the previous push have been resolved — the file is now clean.

Changes Review

The PR wraps three table cell values in JSX expression syntax:

Line Before After
35 <td>&lt; $10M</td> <td>{'< $10M'}</td>
42 <td>$10M – $100M</td> <td>{'$10M – $100M'}</td>
49 <td>$100M – $1B</td> <td>{'$100M – $1B'}</td>

Line 35 — This change is necessary. The < character in MDX can be misinterpreted as an HTML tag opener, so wrapping it in a JSX expression ({'< $10M'}) is the correct fix.

Lines 42 & 49 — These are not strictly necessary since $10M – $100M and $100M – $1B don't contain characters that need escaping. However, keeping them consistent with line 35 is a reasonable style choice and causes no harm.

Verdict

Looks good to merge. The core fix (escaping < on line 35) is correct, and the consistency across all three rows is fine.

@pedromcunha pedromcunha merged commit 80e73c3 into main Mar 27, 2026
4 checks passed
@pedromcunha pedromcunha deleted the fix/fee-doc-table-formatting branch March 27, 2026 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants