DO NOT MERGE

[shutej]

Note the s/relops/shutej/g everywhere. This needs to get fixed before merging.

This adds REAL, DOUBLE PRECISION, and BOOLEAN support.

[0x6e6562]

Sure, I'll wait before it's in a mergeable state before beginning a review.

I'll be interested to see how smoothly the Boolean type works across the three back ends.

[shutej]

it ... doesn't work across all backends. BIT is another type that's
relevant than is probably ANSI, i think. but where BOOLEAN or BOOL exist,
this supports it.

basically the LAST step of the review is subbing the shutej for relops
again. i'll do that when you approve?

Jeremy

On Wed, Jan 7, 2015 at 6:53 PM, Ben Hood notifications@github.com wrote:

Sure, I'll wait before it's in a mergeable state before beginning a review.

I'll be interested to see how smoothly the Boolean type works across the
three back ends.

—
Reply to this email directly or view it on GitHub
#7 (comment).

[0x6e6562]

Fundamentally the patch is a good idea, but to get it into a mergable state, I think the following will be need to be addressed:

• A test case (or an addition to an existing test case) that exercises the change against a real backend - take a look at the existing back end tests if you're unsure about this.
• Having this work across all backends would be nice as well, but that might not be possible.
• Your gofmt settings appear to have made some tab changes, in particular in schema.tmpl, which is used for a lot of the generated code - this has created quite a noisy patch.

[shutej]

Right, I'll install MySQL and test this sucker. :-)

I can un-bork schema.tmpl, but my "settings" are ... the defaults. I
didn't know there WERE settings.

Jeremy

On Thu, Jan 8, 2015 at 9:59 AM, Ben Hood notifications@github.com wrote:

Fundamentally the patch is a good idea, but to get it into a mergable
state, I think the following will be need to be addressed:

• A test case (or an addition to an existing test case) that exercises
  the change against a real backend - take a look at the existing back end
  tests if you're unsure about this.
• Having this work across all backends would be nice as well, but that
  might not be possible.
• Your gofmt settings appear to have made some tab changes, in
  particular in schema.tmpl, which is used for a lot of the generated
  code - this has created quite a noisy patch.

—
Reply to this email directly or view it on GitHub
#7 (comment).

[0x6e6562]

I meant "settings" figuratively - I was just pointing out that there is a divergence in the formatting, not that I know for sure where it is coming from.