Skip to content

Handle broadcast packets in switch #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mullr wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle broadcast packets in switch #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion src/Emulator/Extensions/Tools/Network/Switch.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,6 +113,22 @@ public void DisablePromiscuousMode(IMACInterface iface)
}
}

public void EnableBroadcastUnknown()
{
lock (innerLock)
{
broadcastUnknown = true;
}
}

public void DisableBroadcastUnknown()
{
lock (innerLock)
{
broadcastUnknown = false;
}
}

public void Start()
{
Resume();
Expand Down Expand Up @@ -147,7 +163,7 @@ private void ForwardToReceiver(EthernetFrame frame, IMACInterface sender)
{
var interestingIfaces = macMapping.TryGetValue(frame.DestinationMAC, out var destIface)
? ifaces.Where(x => (x.PromiscuousMode && x.Interface != sender) || x.Interface == destIface)
: ifaces.Where(x => x.Interface != sender);
: ifaces.Where(x => (frame.DestinationMAC.IsBroadcast || broadcastUnknown) && x.Interface != sender);

if(!TimeDomainsManager.Instance.TryGetVirtualTimeStamp(out var vts))
{
Expand Down Expand Up @@ -180,6 +196,7 @@ private void ForwardToReceiver(EthernetFrame frame, IMACInterface sender)
}

private bool started = true;
private bool broadcastUnknown = false;

private readonly object innerLock = new object();
private readonly HashSet<InterfaceDescriptor> ifaces = new HashSet<InterfaceDescriptor>();
Expand Down