fix(coglet): return 503 from /health-check when not ready#2732
Open
fix(coglet): return 503 from /health-check when not ready#2732
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bfirsh
force-pushed
the
fix/health-check-503
branch
from
f2667b6 to
548f853
Compare
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
bfirsh
force-pushed
the
fix/health-check-503
branch
from
548f853 to
de50eaf
Compare
Member
tempusfrangit
left a comment
tempusfrangit
left a comment
There was a problem hiding this comment.
Note this is a behavioral departure from the original cog http server. In the coglet implementation we avoided making this change until we were ready to make breaking changes.
More importantly, is 503 correct while we're in a BUSY state? This is going to matierially change our contract. Likely we want to BUSY to be 429 if anything?
@bfirsh before we land this one we should make sure we want BUSY to be 503. Even as a 429, it is likely we will need to change director and other ecosystem tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/health-checknow returns200only when status isREADY; all other statuses (STARTING,BUSY,SETUP_FAILED,DEFUNCT,UNHEALTHY) return503Builds on #2731.
Test plan
cargo test -p coglet -- health_check— 4 tests passmise run docs:llm:checkpasses🤖 Generated with Claude Code