Remove python from build inputs; bump devShell to python312#18
Open
masad-frost wants to merge 4 commits intomainfrom
Open
Remove python from build inputs; bump devShell to python312#18masad-frost wants to merge 4 commits intomainfrom
masad-frost wants to merge 4 commits intomainfrom
Conversation
Python is only needed for running tests, not for building rtld_loader.so (pure C, compiled with gcc -shared -nostdlib). Removing it from buildInputs fixes consumers that follow nixpkgs-unstable where python310 no longer exists. Bump devShell python from 310 to 312.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking replit/nixmodules#479
Summary
python310frombuildInputs— it's not needed to buildrtld_loader.so(pure C,gcc -shared -nostdlib)python310topython312Why
Consumers like
nixmodulesthat useinputs.replit-rtld-loader.inputs.nixpkgs.follows = "nixpkgs"break when their nixpkgs points to unstable, wherepython310has been removed. Since Python is only used for tests (not the build), it shouldn't be inbuildInputsat all.Test plan
The build produces
rtld_loader.sousing only gcc with no Python dependency — removing it frombuildInputsis a no-op for the build output.~ written by Zerg 👾