containerboot: retrigger cert loops on netmap updates#9
Draft
ryantm wants to merge 1 commit intozerg/operator-wildcard-certfrom
Draft
containerboot: retrigger cert loops on netmap updates#9ryantm wants to merge 1 commit intozerg/operator-wildcard-certfrom
ryantm wants to merge 1 commit intozerg/operator-wildcard-certfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The west1 Orb HA ingress could create its Tailscale Service and serve config, but the shared TLS Secret for
mcp-orb.tail0a469.ts.netstayed empty. Because the HA operator only advertises HTTPS services after certs exist, Orb never gotAdvertiseServicesand never elected a primary VIP advertiser.The issue is in containerboot's cert-loop startup path for HA ingress proxies. It only retriggers the cert manager when the serve config changes or when the first cert domain changes. That misses the case where a new service cert domain is added later in the netmap while the serve config is unchanged.
What changed
NetMap.DNS.CertDomainsset incmd/containerboot/main.goEnsureCertLoopson watcher wakeups incmd/containerboot/serve.go, even when the serve config itself is unchangedTest plan
gofmt -w cmd/containerboot/main.go cmd/containerboot/serve.gogo test ./cmd/containerboot ./kube/certs ./ipn/store/kubestoreNotes
This was validated against the live west1 Orb ingress:
mcp-orb.tail0a469.ts.nethad emptytls.crt/tls.keyAdvertiseServices:["svc:mcp-orb"]and the VIP became reachableThis change makes that cert-loop wakeup happen automatically for future HA ingress services with the same timing pattern.