Open
Conversation
…in doc/ALGORITHM.md
Author
|
Also added a note about how either of the upper/lower bounds being specified results in padding being added even if the versions are the same length. Thats what the C implementation does, and I couldn't get my tests to pass without doing that, so I presume it is the correct thing to do and should be documented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just some things I noticed while implementing a pure ruby fallback for ruby-libversion.
The errata one is self-evident, the letter suffix one I'm adding because I spent a good few hours trying to figure out how exactly to implement it, so I thought I would document what I figured out. If you don't think its necessary, no worries.