Rewatch: warn about deprecated package specs es6/es6-global #8146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rescript
@rescript/darwin-arm64
@rescript/darwin-x64
@rescript/linux-arm64
@rescript/linux-x64
@rescript/runtime
@rescript/win32-x64
commit: |
nojaf
reviewed
Jan 4, 2026
| const { execBuildLegacy } = setup(import.meta.dirname); | ||
| const { execBuild, execClean } = setup(import.meta.dirname); | ||
|
|
||
| const { stdout } = await execBuild(); |
Member
There was a problem hiding this comment.
Should we not first learn what the deal with #8138 is?
cknitt
force-pushed
the
rewatch-warn-package-specs
branch
from
14cc149 to
d4864cd
Compare
nojaf
reviewed
Jan 6, 2026
| const out = await execBuildLegacy(); | ||
| assert.match( | ||
| out.stderr, | ||
| stdout, |
cristianoc
approved these changes
Jan 6, 2026
cknitt
force-pushed
the
rewatch-warn-package-specs
branch
from
d4864cd to
1d2a676
Compare
nojaf
approved these changes
Jan 6, 2026
cknitt
force-pushed
the
rewatch-warn-package-specs
branch
from
1d2a676 to
8182322
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8145