-
Notifications
You must be signed in to change notification settings - Fork 911
fix(react-email): render email templates in separate nodejs process to avoid OOM issues #2888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: canary
Are you sure you want to change the base?
Conversation
|
|
@framebassman is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 1 file
This reverts commit 4c9a2d1.
6461ffd to
644c1f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them.
<file name="packages/react-email/src/commands/testing/stress/export.spec.ts">
<violation number="1" location="packages/react-email/src/commands/testing/stress/export.spec.ts:10">
P2: `fsPromises.rm(emailsDir)` is called without `recursive/force` and the directory is never recreated, so the test will throw ENOENT on first run and `fsPromises.cp` will fail because the parent directory doesn't exist.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
closes #2887
Summary by cubic
Render React Email templates in separate Node.js processes to prevent OOM on large exports. Each render is isolated, reports progress, cleans up, and surfaces clearer errors; fixes #2887.
Written for commit 6515641. Summary will update on new commits.