Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the project’s CI/testing setup by moving off Travis/Mocha to GitHub Actions and Node’s built-in test runner, and adds a prominent README notice about the project’s maintenance status.
Changes:
- Replace Mocha/should-based tests with
node:test+node:assert, and switchnpm testtonode --test. - Remove Travis CI config and add a GitHub Actions workflow to run tests on Ubuntu and Windows.
- Add a README notice recommending migration, plus add
.gitattributes(LF normalization) and commit apackage-lock.jsonfornpm ci.
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| test/stringify.js | Migrates assertions to node:assert/node:test for sourcemap + indent tests. |
| test/parse.js | Migrates parse tests from should to node:assert and node:test. |
| test/cases.js | Removes should dependency and introduces a containDeep helper using node:assert. |
| Readme.md | Updates badges and adds a maintenance-status notice and alternative recommendation. |
| package.json | Removes Mocha/should dev deps and switches test script to node --test. |
| package-lock.json | Adds lockfile needed for npm ci in GitHub Actions. |
| .travis.yml | Removes Travis CI configuration. |
| .github/workflows/test.yml | Adds GitHub Actions matrix CI (Ubuntu/Windows, LTS/latest). |
| .gitattributes | Forces LF checkouts to keep fixtures/tests consistent on Windows. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
100
to
104
| var result = stringify(stylesheet, { sourcemap: true }); | ||
|
|
||
| result.map.sources.should.eql(['/test/source.css']); | ||
| assert.deepStrictEqual(result.map.sources, ['/test/source.css']); | ||
|
|
||
| path.sep = originalSep; |
Comment on lines
16
to
18
| "scripts": { | ||
| "benchmark": "matcha", | ||
| "test": "mocha --require should --reporter spec test/*.js" | ||
| "test": "node --test" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.