Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the messaging and logging within the kdump utility scripts. The primary goal is to standardize warning outputs by removing redundant prefixes and centralizing the 'WARNING:' prefix logic within the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request primarily refactors how warning messages are logged for consistency, by centralizing the "WARNING:" prefix within the dwarn function. This is a good cleanup that improves code maintainability. Additionally, the output logic of the reset_crashkernel function is improved to provide clearer and more accurate feedback to the user. I have one minor suggestion to improve a new log message.
Print informative output when no change is needed. Only show reboot message when memory requirements are satisfied. Signed-off-by: Lichen Liu <lichliu@redhat.com>
The dwarning() is not called anywhere; remove it to simplify the code. Signed-off-by: Lichen Liu <lichliu@redhat.com>
Currently, callers of dwarn() manually prepend prefixes like "WARNING:", "Warning:", or "Notice:". This leads to inconsistent output and redundant string management. Update dwarn() in kdump-logger.sh to automatically include the "WARNING:" prefix. All existing calls to dwarn() have been updated to remove manual prefixes, ensuring a consistent log format across kdumpctl, mkdumprd, and early-kdump. Signed-off-by: Lichen Liu <lichliu@redhat.com>
licliu
force-pushed
the
fix-reset-crashkernel-output
branch
from
31403fa to
f17b90e
Compare
1 participant
No description provided.