Github example project tests #8779
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds comprehensive tests to verify that example projects not only initialize correctly but also: 1. All resources reconcile successfully (no pending/running states) 2. No critical resources (models, metrics views, explores) have errors 3. Dashboards can be previewed without 404 errors The tests address the intermittent 404/500 errors reported in ENG-1031 by: - Adding utility functions to poll resource reconciliation status - Checking for reconcile errors on critical resources - Verifying dashboard preview renders without error pages - Separating tests for DuckDB examples (reliable) vs GitHub Analytics (depends on external GCS data) Files added: - web-local/tests/example-projects.spec.ts: Comprehensive test suite - web-local/tests/utils/exampleProjectHelpers.ts: Helper utilities Related: ENG-1031 Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
|
Cursor Agent can help with this pull request. Just |
The model reconciler already has retry logic, but the default error patterns were too narrow to catch common network/HTTP failures when loading data from external sources like GCS. This expands the default retry patterns to include: - HTTP 5xx errors (500, 502, 503, 504) - Connection failures (refused, reset, broken pipe) - DNS resolution failures - TLS handshake timeouts - IO timeouts and EOF errors This helps address intermittent failures when example projects load data from external sources like GCS. Related: ENG-1031 Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
- Fixed prettier formatting issues in test files - Removed unused getDashboardNameFromExample import Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses ENG-1031 by adding comprehensive Playwright tests for example projects.
The previous tests only verified file unpacking, which allowed issues like the broken GitHub example (due to external GCS data or reconciliation failures) to slip into releases, causing 404/500 errors.
These new tests ensure that:
This prevents regressions where example projects appear to load but fail to display functional dashboards.
Checklist:
Linear Issue: ENG-1031