Hide Discord and support links in embedded contexts#9135
Open
Hide Discord and support links in embedded contexts#9135
Conversation
- CTANeedHelp: check EmbedStore.isEmbedded() and hide Discord link - PivotEmpty: wrap Discord help link in isFetching state with isEmbedded guard - TimeDimensionDisplay: hide Discord contact link in error state when embedded - DashboardErrored: hide Discord help link when embedded Resolves APP-824 Co-authored-by: ericokuma <ericokuma@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When customers embed Rill dashboards, we were displaying links to our Discord community and other Rill-specific support surfaces. This PR hides those links when dashboards are shown in embedded contexts.
Changes
CTANeedHelp.svelte— The shared "Need help? Reach out to us on Discord" component now checksEmbedStore.isEmbedded()and renders nothing in embedded contexts. This covers all surfaces using this component:DashboardBuilding,ProjectBuilding,OrganizationHibernating, etc.PivotEmpty.svelte— The Discord help link shown during the "building your table" loading state (the exact surface shown in the issue screenshot) is now hidden whenisEmbeddedis true. The component already had this prop for gating docs links.TimeDimensionDisplay.svelte— The Discord contact link in the error state is now hidden in embedded contexts usingEmbedStore.isEmbedded().DashboardErrored.svelte— The Discord help link on the dashboard error page is now hidden in embedded contexts usingEmbedStore.isEmbedded().Closes APP-824
Checklist:
Linear Issue: APP-824