Conversation
Add \$Slots interface so `let:rootCauseReconcileError` in CanvasWorkspace and ExploreWorkspace passes TypeScript validation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
- Add `interface \$\$Slots` to declare the `rootCauseReconcileError` slot prop type so svelte-check accepts `let:rootCauseReconcileError` in consumers - Add `varsIgnorePattern: "^\$\$"` to ESLint no-unused-vars so Svelte's reserved `\$\$`-prefixed type declarations (Slots, Props, Events) are not flagged as unused Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Remove the slot prop pattern from WorkspaceError (which required an unidiomatic \$\$Slots declaration). Canvas and Explore now compute rootCauseReconcileError in their own script for use in their content area; WorkspaceError still owns the single error bar. TanStack Query deduplicates the ListResources request so there is no extra network cost. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
AdityaHegde
requested changes
Mar 31, 2026
| $: error = parseError?.message ?? rootCauseReconcileError; | ||
| </script> | ||
|
|
||
| <WorkspaceEditorContainer {error} showError={!!remoteContent}> |
Collaborator
There was a problem hiding this comment.
How about we move this logic into WorkspaceEditorContainer. Right now it feels weird that WorkspaceError wraps WorkspaceEditorContainer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lots of changes and looks like this functionality was lots
Checklist: