Skip to content

updating ttl to 14days#9446

Open
NamanMahor wants to merge 2 commits into
mainfrom
namanmahor/plat-474-pentest-set-expires_on-for-browser-tokens
Open

updating ttl to 14days#9446
NamanMahor wants to merge 2 commits into
mainfrom
namanmahor/plat-474-pentest-set-expires_on-for-browser-tokens

Conversation

@NamanMahor
Copy link
Copy Markdown
Contributor

@NamanMahor NamanMahor commented May 14, 2026

PLAT-474: Pentest: Set expires_on for browser tokens

Checklist:

  • Covered by tests
  • Ran it and it works as intended
  • Reviewed the diff before requesting a review
  • Checked for unhandled edge cases
  • Linked the issues it closes
  • Checked if the docs need to be updated. If so, create a separate Linear DOCS issue
  • Intend to cherry-pick into the release branch
  • I'm proud of this work!

Comment thread admin/server/auth/handlers.go Outdated
return
}
newAuthToken, err := a.admin.IssueUserAuthToken(r.Context(), validated.OwnerID(), database.AuthClientIDRillWeb, "Browser session", nil, nil, false)
ttl := 14 * 24 * time.Hour
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its defined at two places, Factor out as one constant ?

@NamanMahor NamanMahor requested a review from nishantmonu51 May 15, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants