Per slot disk configuration in the helm charts#9448
Open
himadrisingh wants to merge 3 commits into
Open
Conversation
kaspersjo
requested changes
May 14, 2026
| } | ||
|
|
||
| // Resolve disk_gb_per_slot from env var if set | ||
| if val := os.Getenv("RILL_PROVISIONER_DISK_GB_PER_SLOT"); val != "" { |
Contributor
There was a problem hiding this comment.
We don't load environment variables directly like this. All configs are parsed and passed through from the Config struct in cli/cmd/admin/start.go
| TimeoutSeconds int `json:"timeout_seconds"` | ||
| KubeconfigPath string `json:"kubeconfig_path"` | ||
| TemplatePaths *KubernetesTemplatePaths `json:"template_paths"` | ||
| DiskGBPerSlot int `json:"disk_gb_per_slot"` |
Contributor
There was a problem hiding this comment.
We should probably make the entire slot definition configurable if we go down this path, but that would be more than a provisioner change, since it affects more parts of the application.
himadrisingh
changed the title
himadrisingh
commented
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make it configurable via env
Checklist: