use asset bundle of inherited widget instead of root#330
Open
lunaticcoding wants to merge 7 commits intorive-app:masterfrom
Open
use asset bundle of inherited widget instead of root#330lunaticcoding wants to merge 7 commits intorive-app:masterfrom
lunaticcoding wants to merge 7 commits intorive-app:masterfrom
Conversation
Author
|
@mjtalbot Any update? |
Contributor
thank you for the prod, let me chase this one down |
mjtalbot
reviewed
Jul 18, 2023
| void initState() { | ||
| super.initState(); | ||
| _configure(); | ||
| WidgetsBinding.instance.addPostFrameCallback((_) => _configure()); |
Contributor
There was a problem hiding this comment.
this is the main concern with this PR.
Presumably this pushes the first frame of the animation back a render cycle? I am guessing this is to ensure that the context has been loaded before loadRiveFile is executed?
Author
|
sorry for the late response I'll take a look over the weekend on how this could be avoided :) I already have an idea |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One should never use rootBundle because it cannot be overridden for example during testing. It's better to use DefaultAssetBundle.of(context).