Enable cloning in memory to speed up rive load when using runtime asset swapping#434
Open
tguerin wants to merge 1 commit intorive-app:masterfrom
Open
Enable cloning in memory to speed up rive load when using runtime asset swapping#434tguerin wants to merge 1 commit intorive-app:masterfrom
tguerin wants to merge 1 commit intorive-app:masterfrom
Conversation
Contributor
|
This is great, @tguerin; we'll get this reviewed as soon as possible. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When using
AssetLoaderfor runtime asset swapping, there is no straightforward way to reuse aRiveFile. Each time it's needed, it must be re-imported. While debugging performance, I noticed a significant amount of time was spent in the_readRuntimeObjectmethod, leading to inefficiencies.To address this, I implemented a caching mechanism to store
RiveFileobjects and enable cloning them directly in memory. This eliminates the need for repetitive re-imports and significantly reduces loading overhead.This change resulted in a substantial improvement in loading times, with a performance boost of 4x to 10x depending on the use case.
What do you think about this approach? Are there any additional considerations or potential pitfalls I should address?