fix: compile on Elixir 1.20.x when comeonin is not present.#72
Open
jimsynz wants to merge 1 commit into
Open
Conversation
`comeonin` is an optional dependency of argon2_elixir, however it is directly referenced in the code. To be honest I'm not sure how this ever worked, but maybe because `__using__` is a macro that makes it different? Anyway, the typechecker is now trying to enter `comeonin` and use it for type inference. Closes riverrun#71.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
comeoninis an optional dependency of argon2_elixir, however it is directly referenced in the code. To be honest I'm not sure how this ever worked, but maybe because__using__is a macro that makes it different? Anyway, the typechecker is now trying to entercomeoninand use it for type inference.Closes #71.