fix: correct OfflineProgressStatus TypeScript type and TileRegionPackState typo#4223
Open
PHILLIPS71 wants to merge 3 commits into
Open
fix: correct OfflineProgressStatus TypeScript type and TileRegionPackState typo#4223PHILLIPS71 wants to merge 3 commits into
PHILLIPS71 wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Corrects the
OfflineProgressStatusTypeScript type, which had several inaccuracies compared to what the native modules (Android/iOS) actually emit:statewas typed asnumberbut is always a string, so it was changed to a strict union:'invalid' | 'inactive' | 'active' | 'complete' | 'unknown'completedTileCountandcompletedTileSizethat were never emitted by native codeerroredResourceCount,loadedResourceSize,loadedResourceCountpercentageto accurately model the two distinct payload shapes: one with full progress data and one emitted when a pack exists but has not yet started loading (percentage isnulland resource counts are absent)OfflinePackDownloadStatevalues inRNMBXModule.tsfromstring | numbertostring, consistent with what native actually sendsTileRegionPackState.UNKNOWNon Android:"unkown"to"unknown"Checklist
CONTRIBUTING.mdyarn generatein the root folder/exampleapp./example)Screenshot OR Video
N/A type-only changes with one runtime string correction on Android.
Component to reproduce the issue you're fixing