Skip to content

Fix wildcard imports and resource leak #3033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chelslava wants to merge 1 commit into
base: develop
Choose a base branch
from
+5 −4
Open

Fix wildcard imports and resource leak #3033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/robotide/application/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,6 @@
# limitations under the License.

from .application import RIDE
from .debugconsole import *
from . import debugconsole
from ..controller import Project
from .editorprovider import EditorProvider
7 changes: 4 additions & 3 deletions src/robotide/publish/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,10 +120,11 @@ def important_action(self):

import os

from .messages import *
from .messages import * # Wildcard import OK: messages.py defines __all__
from .publisher import PUBLISHER


def get_html_message(name):
return open(os.path.join(
os.path.dirname(__file__), 'htmlmessages', '{}.html'.format(name))).read()
path = os.path.join(os.path.dirname(__file__), 'htmlmessages', f'{name}.html')
with open(path, encoding='utf-8') as f:
return f.read()
Loading