Interpreter and other classes have been modified for support null args#232
Open
bisegni wants to merge 1 commit intoroot-project:masterfrom
Open
Interpreter and other classes have been modified for support null args#232bisegni wants to merge 1 commit intoroot-project:masterfrom
bisegni wants to merge 1 commit intoroot-project:masterfrom
Conversation
pcanal
requested changes
May 7, 2018
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
Please separate the white-space/layout changes from the active changes. Thanks.
| std::vector<const char*> argvCompile; | ||
| if(argc && argv) { | ||
| argvCompile = std::vector<const char*>(argv, argv+1); | ||
| } |
Member
There was a problem hiding this comment.
It might be better/needed to have a non-empty default for argvCompile?
Author
There was a problem hiding this comment.
Thanks for replay, this is a first patch, to permit to use it. I'd like to share ideas on the architectural design to follow.
Contributor
There was a problem hiding this comment.
I think this repo is just a mirror, consider moving your PR here instead: https://github.com/root-project/root/pulls (subdirectory interpreter/cling). Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch permit to use interpreter without give the argc(0) and argv(nullptr)