Skip to content

Prepare roottest for ROOT 7's ownership model#21225

Merged
hageboeck merged 5 commits intoroot-project:masterfrom
hageboeck:root7-ownership-9
Feb 26, 2026
Merged

Prepare roottest for ROOT 7's ownership model#21225
hageboeck merged 5 commits intoroot-project:masterfrom
hageboeck:root7-ownership-9

Conversation

@hageboeck
Copy link
Member

In essence, add histo.SetDirectory(xxx) to all places where a histogram should show up in a TDirectory independent of whether it has been registered automatically.

@github-actions
Copy link

github-actions bot commented Feb 10, 2026

Test Results

    22 files      22 suites   3d 3h 45m 55s ⏱️
 3 800 tests  3 797 ✅ 1 💤 2 ❌
75 511 runs  75 500 ✅ 9 💤 2 ❌

For more details on these failures, see this check.

Results for commit 38b6fdd.

♻️ This comment has been updated with latest results.

@hageboeck hageboeck requested a review from pcanal February 11, 2026 13:00
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should enhanced this PR by adding a new test that checks the current memory ownership explicitly (Otherwise we no longer test the current/main-stream usages)

@hageboeck
Copy link
Member Author

hageboeck commented Feb 12, 2026

We should enhanced this PR by adding a new test that checks the current memory ownership explicitly (Otherwise we no longer test the current/main-stream usages)

That's a very good idea, and it's now implemented in the "master" PR for this feature. I'll cherry-pick the commit that will work already in ROOT 6 mode into this PR next.

Edit: Done

@hageboeck hageboeck force-pushed the root7-ownership-9 branch 2 times, most recently from 9a31bdc to 5fe91b4 Compare February 13, 2026 15:06
@hageboeck hageboeck requested a review from pcanal February 19, 2026 09:25
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@hageboeck
Copy link
Member Author

Only the known failures, merging ...

@hageboeck hageboeck merged commit 3b5d581 into root-project:master Feb 26, 2026
27 of 30 checks passed
@hageboeck hageboeck deleted the root7-ownership-9 branch February 26, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants