Prepare roottest for ROOT 7's ownership model#21225
Prepare roottest for ROOT 7's ownership model#21225hageboeck merged 5 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 3h 45m 55s ⏱️ For more details on these failures, see this check. Results for commit 38b6fdd. ♻️ This comment has been updated with latest results. |
pcanal
left a comment
There was a problem hiding this comment.
We should enhanced this PR by adding a new test that checks the current memory ownership explicitly (Otherwise we no longer test the current/main-stream usages)
That's a very good idea, and it's now implemented in the "master" PR for this feature. I'll cherry-pick the commit that will work already in ROOT 6 mode into this PR next. Edit: Done |
f39f216 to
d1c4b79
Compare
9a31bdc to
5fe91b4
Compare
5fe91b4 to
8454720
Compare
The test was relying on implicit ownership to transfer a histogram from python to C++, so now the histogram is appended explicitly.
8454720 to
38b6fdd
Compare
|
Only the known failures, merging ... |
In essence, add
histo.SetDirectory(xxx)to all places where a histogram should show up in a TDirectory independent of whether it has been registered automatically.