Skip to content

[main] Rewrite rootrm in C++#21312

Merged
silverweed merged 8 commits intoroot-project:masterfrom
silverweed:rootrm_cxx
Feb 26, 2026
Merged

[main] Rewrite rootrm in C++#21312
silverweed merged 8 commits intoroot-project:masterfrom
silverweed:rootrm_cxx

Conversation

@silverweed
Copy link
Contributor

@silverweed silverweed commented Feb 18, 2026

This PR introduces a C++ version of rootrm, replacing the python version.
The semantics are mostly the same, but there is a new -n flag to do a "dry run" (useful for testing).

Note that this doesn't currently fix #21090

Checklist:

  • tested changes locally

@silverweed silverweed self-assigned this Feb 18, 2026
@silverweed silverweed force-pushed the rootrm_cxx branch 2 times, most recently from ed0ea67 to 3cf3d57 Compare February 18, 2026 14:09
Copy link
Member

@pcanal pcanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@github-actions
Copy link

github-actions bot commented Feb 18, 2026

Test Results

    22 files      22 suites   3d 5h 12m 46s ⏱️
 3 800 tests  3 795 ✅ 0 💤 5 ❌
75 582 runs  75 577 ✅ 0 💤 5 ❌

For more details on these failures, see this check.

Results for commit 469175b.

♻️ This comment has been updated with latest results.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is great! Just a few minor questions from my side.

Copy link
Member

@vepadulano vepadulano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, thanks!

@silverweed silverweed merged commit a8bc45d into root-project:master Feb 26, 2026
26 of 30 checks passed
@silverweed silverweed deleted the rootrm_cxx branch February 26, 2026 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rootrm does not 'delete' the record for TBaskets

4 participants